Skip to content

xds: Store WeightedClusters as a slice instead of a map inside the Route #8632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2025
Merged

xds: Store WeightedClusters as a slice instead of a map inside the Route #8632

merged 1 commit into from
Oct 8, 2025

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Oct 6, 2025

Reasons for this change:

  • The WeightedClusters field is never used as a map.
  • Weighted clusters are stored as a list in the original envoy proto as well.
  • In tests that require deterministic WRR behavior, we use the testutils.NewTestWRR to get rid of the randomness. But the output still depends on the order in which items are added to the WRR. Maps in Go are non-deterministic.

RELEASE NOTES: N/A

@easwars easwars added Type: Internal Cleanup Refactors, etc Area: xDS Includes everything xDS related, including LB policies used with xDS. labels Oct 6, 2025
@easwars easwars added this to the 1.77 Release milestone Oct 6, 2025
@codecov Codecov
Copy link

codecov bot commented Oct 6, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.07%. Comparing base (8389ddb) to head (251d230).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8632      +/-   ##
==========================================
- Coverage   82.13%   82.07%   -0.06%     
==========================================
  Files         415      415              
  Lines       40711    40710       -1     
==========================================
- Hits        33437    33412      -25     
- Misses       5897     5914      +17     
- Partials     1377     1384       +7
Files with missing lines Coverage Δ
internal/xds/resolver/xds_resolver.go 81.76% <100.00%> (ø)
...nternal/xds/xdsclient/xdsresource/unmarshal_rds.go 87.57% <100.00%> (-0.04%) ⬇️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eshitachandwani eshitachandwani removed their assignment Oct 8, 2025
@easwars easwars merged commit 20c9f65 into grpc:master Oct 8, 2025
15 of 18 checks passed
@easwars easwars deleted the clusters_list_and_not_map branch October 8, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshitachandwani eshitachandwani eshitachandwani approved these changes

@arjan-bal arjan-bal Awaiting requested review from arjan-bal

Assignees

@arjan-bal arjan-bal

Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.77 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@easwars @eshitachandwani @arjan-bal